Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customizing SymbolLookup for tree-sitter native library #61
base: master
Are you sure you want to change the base?
Support customizing SymbolLookup for tree-sitter native library #61
Changes from all commits
356a15a
3846ad4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As side note: This fallback with
SymbolLookup.loaderLookup()
probably still requires that the users call eitherSystem#loadLibrary
orSystem#load
, and even then onlySystem#loadLibrary
is affected byjava.library.path
.So maybe it would be good to update the package Javadoc (which lists requirements and shows usage) to
System#loadLibrary
orSystem#load
(and maybe not even mention
java.library.path
)NativeLibraryLookup
interface, otherwise it might be easy to missWhat do you think @ObserverOfTime?