Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Guava Throwables.propagate #223

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Inline Guava Throwables.propagate #223

merged 1 commit into from
Jan 26, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jan 26, 2023

Part of #135

https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate

In many cases, you'll be able to use throw e or throw new RuntimeException(e) with no change in behavior. This sometimes lets you remove other code.

@exoego exoego marked this pull request as ready for review January 26, 2023 04:27
@exoego exoego added the dependencies Pull requests that update a dependency file label Jan 26, 2023
@exoego exoego merged commit 1507083 into master Jan 26, 2023
@exoego exoego deleted the propagate branch January 26, 2023 13:06
@exoego exoego added chore internal changes (not user-facing) and removed dependencies Pull requests that update a dependency file labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuokada yuokada yuokada approved these changes

Assignees
No one assigned
Labels
chore internal changes (not user-facing)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @yuokada