Enable reliable fetch for Sidekiq #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Since Tramline is very job-heavy and relies on them for critical tasks, we want our task queues to be reliable. This feature is available in the Sidekiq pro version but not in the open-source Sidekiq version that we use. We add this gem to add reliability to our job processing where, if the worker dies or there's a network interruption, messages are not lost (we're strictly talking about messages being processed, not the ones in scheduled / retry / dead queue).
Notes
Git-vendor the GitLab gem sidekiq-reliable-fetch directly since the previously available gem is not maintained anymore.