Structured logging + erb_lint + pry debugger #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitallis
force-pushed
the
better-logging
branch
from
abf78f8 to
0a21154
Compare
kitallis
force-pushed
the
better-logging
branch
from
6a1f9ee to
96edea3
Compare
kitallis
force-pushed
the
better-logging
branch
from
96edea3 to
158440a
Compare
kitallis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging
All
elogshould also take mandatorily take alevel. On sentry:erroris High Priority,warnis Medium,debugis Low. Alerts from Sentry to Slack only happen on High.Development (and test) logs are now back to standard rails logs. Production continues to be structured. This is because there are certain TurboStream::Channel and ActionCable logs that get swallowed under lograge because those libraries implement logging poorly.
Revived a quick log helper in dev called
d. Which can be used to log a variable with its name simultaneously.Sidekiq will automatically log to sentry when a job goes to dead-queue as
errorand it will log to sentry when a job fails aswarn(medium priority).Dead code
Removed some dead code and cleaned up the related TODOs.
Byebug
We now use
pry-byebuginstead of justpryfor a proper debugging experience. See arguments and guides.