Using radixtree for check spatialIDs' overlap #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using altitude index conversion To avoid cycle import between `integrate` and `transform`, check_spatial_id_overlap.go moved to new package
refactored convertZToMinAltitudekey to reuse index boundary check
multi-dimensional-radix-tree
Merge branch 'refs/heads/develop' into feature/using-radixtree-detectoverlap
Merge branch 'refs/heads/develop' into feature/using-radixtree-detectoverlap
It needs receiver if implementing tree cache;
```
type detector struct {
tr tree.TreeInterface
}
func CheckSpatialIdsArrayOverlapWithCache(spatialIds1 tree.TreeInterface, spatialIds2 []string) (bool, error){
// ...
}
```
This reverts commit de00e69
HarutakaMatsumoto
requested changes
Oct 16, 2024
| // AddZBaseOffsetToZ (拡張)空間IDz成分(fインデックス)にオフセット加算する | ||
| // ConvertZToAltitudekey()でズームレベル変換を行わずオフセット変換のみ指定したもの | ||
| // | ||
| // したがって ConvertZToAltitudekey(f, z, z, consts.ZBaseExponent, zBaseOffset)と等価 |
There was a problem hiding this comment.
Memo: Change over from AddZBaseOffsetToZ(_) to convertZToMinAltitudekey(_).
test/detect_overlap/main.go
Outdated
|
|
||
| const maxCases = 10 | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
Memo: Move this folder to examples/detectOverlap/main.go.
for `CheckSpatialIdsArrayOverlap`
it found that `AddZBaseOffsetToZ` is not useful since it is slower than `ConvertZToMinMaxAltitudekey`, and this function existence only matters when `AddZBaseOffsetToZ` is faster than `ConvertZToMinAltitudekey`.
|
@mi-24v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckSpatialIdsOverlapandCheckSpatialIdsArrayOverlapdetectorpackage to prevent cycle import