Fix CI builds #15
Merged
Fix CI builds #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
fix-ci
branch
29 times, most recently
from
89f5dff to
1bb55eb
Compare
facutuesca
force-pushed
the
fix-ci
branch
13 times, most recently
from
bfee2d4 to
bf3db25
Compare
|
Wahoo - thanks a lot for the work here @facutuesca Since we end up paying a lot for our MacOS runners - would it make sense to disable them at push time and only run them periodically ? |
facutuesca
temporarily deployed
to
macos-ci-jobs
GitHub Actions
Inactive
facutuesca
temporarily deployed
to
macos-ci-jobs
GitHub Actions
Inactive
Yeah I think limiting the MacOS runs makes sense. I added a GitHub environment and tied the MacOS job to it, so that jobs will only run when someone manually approves them (docs). This way we can approve them manually right before merging, so that they only run once per PR. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the OpenSSL libs needed to be installed in order to build. This is easy when compiling for the same target architecture as the host, but when cross-compiling you need to get the libraries for the target architecture.
What this PR does is enable the
vendoredfeature for theopensslcrate, which builds OpenSSL from source for the target architecture. This is used only for the LInux builds.For the MacOS builds, we simply use the OpenSSL libs already available on the runner (to avoid using more time than necessary on the GHA MacOS runners). For Windows builds, we download and install the libs in order to also avoid compiling OpenSSL.
This should fix #19, since the high-consumption was due to me running the CI over and over in order to test the different builds. Consumption should be normal from now on.