From 310e7947ff3e17aeddfb21e5968537f60593e5b7 Mon Sep 17 00:00:00 2001 From: Sebastian Dietrich Date: Sun, 27 Aug 2023 17:42:59 +0200 Subject: [PATCH] Revert to using genshi.builder.tag because the code is not yet compatible with trac.util.html.tag genshi.builder.tag converts attribute names like 'data_base_url' to 'data-base-url' which makes them accessible by jQuery's .data() API. trac.util.html.tag does not do that. fixes regression in fa7cdff4500f3a2a215645d3cd5470833dfca624 --- code_comments/subscription.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code_comments/subscription.py b/code_comments/subscription.py index cbe14dc..913c2db 100644 --- a/code_comments/subscription.py +++ b/code_comments/subscription.py @@ -6,11 +6,11 @@ from trac.admin import IAdminCommandProvider from trac.attachment import Attachment, IAttachmentChangeListener from trac.core import Component, implements -from trac.util.html import html as tag from trac.versioncontrol import ( RepositoryManager, NoSuchChangeset, IRepositoryChangeListener) from trac.web.api import HTTPNotFound, IRequestHandler, ITemplateStreamFilter +from genshi.builder import tag # Note that trac.util.html.html is NOT a drop-in replacement. (see #85) from genshi.filters import Transformer from code_comments.api import ICodeCommentChangeListener