Skip to content

Commit

Permalink
Revert to using genshi.builder.tag because the code is not yet compat…
Browse files Browse the repository at this point in the history
…ible with trac.util.html.tag

genshi.builder.tag converts attribute names like 'data_base_url' to 'data-base-url' which makes them accessible by jQuery's .data() API. trac.util.html.tag does not do that.

fixes regression in fa7cdff
  • Loading branch information
SebDieBln committed Aug 27, 2023
1 parent aa945a8 commit 310e794
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code_comments/subscription.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
from trac.admin import IAdminCommandProvider
from trac.attachment import Attachment, IAttachmentChangeListener
from trac.core import Component, implements
from trac.util.html import html as tag
from trac.versioncontrol import (
RepositoryManager, NoSuchChangeset, IRepositoryChangeListener)
from trac.web.api import HTTPNotFound, IRequestHandler, ITemplateStreamFilter

from genshi.builder import tag # Note that trac.util.html.html is NOT a drop-in replacement. (see #85)
from genshi.filters import Transformer

from code_comments.api import ICodeCommentChangeListener
Expand Down

0 comments on commit 310e794

Please sign in to comment.