Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] style: set a fixed height to criteria icons in CriteriaButtonsScoreReview.tsx #2035

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

GresilleSiffle
Copy link
Collaborator

@GresilleSiffle GresilleSiffle commented Nov 28, 2024

Description

This PR defines a common height for all displayed criteria icons in the component <CriteriaButtonsScoreReview>. The icons should stay aligned regardless of the browser font size.

The height of the criteria icons has been set to match the size of the biggest icon: important & actionable.

before after
capture0 capture

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@GresilleSiffle GresilleSiffle self-assigned this Nov 28, 2024
@GresilleSiffle GresilleSiffle added the Frontend Front-end code of Tournesol label Nov 28, 2024
@GresilleSiffle GresilleSiffle added this to the Mobile Friendliness milestone Nov 28, 2024
@GresilleSiffle GresilleSiffle marked this pull request as ready for review November 28, 2024 14:33
@GresilleSiffle GresilleSiffle merged commit 9b41eeb into main Nov 28, 2024
6 checks passed
@GresilleSiffle GresilleSiffle deleted the front-fix_set_height_of_criteria_buttons branch November 28, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Front-end code of Tournesol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants