-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[front] feat: display entity contexts on comparison page #1858
Conversation
4f7203a
to
6769ff9
Compare
8e4ebda
to
df5bf4d
Compare
df5bf4d
to
f45c2d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
* corresponding localized entity contexts. | ||
*/ | ||
useEffect(() => { | ||
if (initializing.current || isLoading) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this check on initliazing.current
is useful here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and it's not useful, the isLoading
check seems to be enough.
Co-authored-by: Adrien Matissart <amatissart@users.noreply.github.com>
related issues #1852
Description
This PR displays the entity contexts in the comparison interface.
The boxes can be collapsed, and this state is saved per entity in the browser local storage.
On small screens and mobile, the two boxes stack on top of each other.
to-do
Preview
The title of the entity is also displayed before the context to connect more explicitly the entity with its context.
The following captures have been made before the introduction of the entity title.
Checklist