Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] fix: maintenance page could not load static assets #1826

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

amatissart
Copy link
Member

@amatissart amatissart commented Nov 2, 2023

Description

The maintenance mode was not defined properly in Nginx configuration: all assets would redirect return a response code 503, causing the browser to not display them.

This PR defines a separate location /maintenance section to serve the static page as expected.

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@GresilleSiffle GresilleSiffle added the Bug Something isn't working label Nov 2, 2023
@GresilleSiffle GresilleSiffle merged commit 7893886 into main Nov 6, 2023
@GresilleSiffle GresilleSiffle deleted the fix-maintenance-page branch November 6, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants