front: do not forward the offset param to the search page (but restor…

…e it when going backward)
tournesol-app · Dec 19, 2024 · 8c3f5f4 · 8c3f5f4
1 parent 1331217
commit 8c3f5f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/frontend/src/pages/feed/FeedForYou.tsx b/frontend/src/pages/feed/FeedForYou.tsx
@@ -62,10 +62,10 @@ const FeedForYou = () => {
     dispatch(
       updateBackNagivation({
         backPath: location.pathname,
-        backParams: '',
+        backParams: offset > 0 ? `offset=${offset}` : '',
       })
     );
-  }, [dispatch, location.pathname]);
+  }, [dispatch, location.pathname, offset]);
 
   useEffect(() => {
     const searchString = new URLSearchParams(userPreferences);
@@ -95,12 +95,6 @@ const FeedForYou = () => {
     fetchEntities();
   }, [criterias, offset, options, pollName, userPreferences]);
 
-  const makeSearchPageSearchParams = () => {
-    const searchPageSearchParams = new URLSearchParams(userPreferences);
-    searchPageSearchParams.set('offset', offset.toString());
-    return searchPageSearchParams;
-  };
-
   return (
     <>
       <ContentHeader
@@ -122,9 +116,7 @@ const FeedForYou = () => {
           justifyContent="flex-end"
           gap={1}
         >
-          <SearchIconButtonLink
-            params={makeSearchPageSearchParams().toString()}
-          />
+          <SearchIconButtonLink params={userPreferences.toString()} />
           <PreferencesIconButtonLink hash={`#${pollName}-feed-foryou`} />
         </Box>
         {!isLoading && entities.count === 0 && (

diff --git a/frontend/src/pages/feed/FeedTopItems.tsx b/frontend/src/pages/feed/FeedTopItems.tsx
@@ -155,7 +155,7 @@ const FeedTopItems = () => {
       new URLSearchParams(location.search),
       ALLOWED_SEARCH_PARAMS
     );
-    searchPageSearchParams.set('offset', offset.toString());
+    searchPageSearchParams.delete('offset');
     return searchPageSearchParams;
   };