Skip to content

Commit

Permalink
Merge pull request #40 from toshi0607/feature/v0.2
Browse files Browse the repository at this point in the history
v0.2
  • Loading branch information
toshi0607 authored Sep 28, 2020
2 parents 9c5e32b + dad97bb commit 532c5dd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Binary file modified docs/images/trend.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 5 additions & 4 deletions terraform/development/google_cloud_run_service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ resource "google_cloud_run_service" "kompal-weather-dev" {
name = "kompal-weather-dev2"
location = var.gcp_region

autogenerate_revision_name = false
// When false, changing configuration fails because the run service try to created a service with the existing name
autogenerate_revision_name = true

traffic {
latest_revision = true
Expand Down Expand Up @@ -64,7 +65,7 @@ resource "google_cloud_run_service" "kompal-weather-dev" {
}
env {
name = "VERSION"
value = "0.1.0"
value = "0.2.0"
}
env {
name = "SERVICE_NAME"
Expand Down Expand Up @@ -102,7 +103,7 @@ resource "google_cloud_run_service" "kompal_weather_visualizer_dev" {
name = "kompal-weather-visualizer-dev"
location = var.gcp_region

autogenerate_revision_name = false
autogenerate_revision_name = true

traffic {
latest_revision = true
Expand Down Expand Up @@ -135,7 +136,7 @@ resource "google_cloud_run_service" "kompal_weather_visualizer_dev" {
}
env {
name = "VERSION"
value = "0.1.0"
value = "0.2.0"
}
env {
name = "ENVIRONMENT"
Expand Down

0 comments on commit 532c5dd

Please sign in to comment.