Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.1 #17

Merged
merged 5 commits into from
May 20, 2024
Merged

Wagtail 6.1 #17

merged 5 commits into from
May 20, 2024

Conversation

@katdom13 katdom13 self-assigned this May 16, 2024
@katdom13
Copy link
Collaborator Author

I had to bump the minimum Wagtail version to 5.2 since older ones have reached EOL. Same for the Django versions

@katdom13 katdom13 requested a review from nickmoreton May 16, 2024 08:44
Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katdom13 This all looks good. Just one update looks like is needed on the Makefile

python ./tests/testapp/manage.py dumpdata --indent=4 -e contenttypes -e auth.permission -e auth.group -e sessions -e wagtailcore.site -e wagtailcore.pagerevision -e wagtailcore.grouppagepermission -e wagtailimages.rendition -e wagtailcore.collection -e wagtailcore.groupcollectionpermission > tests/testapp/fixtures/test_data.json

I noticed that running the update-test-fixture command failed and it was because the fixtures file is in a different location in the home app.

Also the fixtures end up with data that's new in wagtail but isn't excluded.

This should help with modernising it.

update-test-fixture: ## Update test fixture from the db.
	python ./tests/testapp/manage.py dumpdata --indent=4 \
	-e contenttypes -e auth.permission -e auth.group -e sessions \
	-e wagtailcore.site -e wagtailcore.revision -e wagtailcore.grouppagepermission \
	-e wagtailimages.rendition -e wagtailcore.collection -e wagtailcore.groupcollectionpermission \
	-e wagtailcore.locale \
	-e wagtailcore.workflowpage -e wagtailcore.workflowtask -e wagtailcore.task -e wagtailcore.workflow -e wagtailcore.groupapprovaltask \
	> tests/testapp/home/fixtures/test_data.json

@katdom13 katdom13 requested a review from nickmoreton May 17, 2024 12:04
@katdom13
Copy link
Collaborator Author

Hi @katdom13 This all looks good. Just one update looks like is needed on the Makefile

python ./tests/testapp/manage.py dumpdata --indent=4 -e contenttypes -e auth.permission -e auth.group -e sessions -e wagtailcore.site -e wagtailcore.pagerevision -e wagtailcore.grouppagepermission -e wagtailimages.rendition -e wagtailcore.collection -e wagtailcore.groupcollectionpermission > tests/testapp/fixtures/test_data.json

I noticed that running the update-test-fixture command failed and it was because the fixtures file is in a different location in the home app.

Also the fixtures end up with data that's new in wagtail but isn't excluded.

This should help with modernising it.

update-test-fixture: ## Update test fixture from the db.
	python ./tests/testapp/manage.py dumpdata --indent=4 \
	-e contenttypes -e auth.permission -e auth.group -e sessions \
	-e wagtailcore.site -e wagtailcore.revision -e wagtailcore.grouppagepermission \
	-e wagtailimages.rendition -e wagtailcore.collection -e wagtailcore.groupcollectionpermission \
	-e wagtailcore.locale \
	-e wagtailcore.workflowpage -e wagtailcore.workflowtask -e wagtailcore.task -e wagtailcore.workflow -e wagtailcore.groupapprovaltask \
	> tests/testapp/home/fixtures/test_data.json

HI @nickmoreton ,
Applied suggestion here:
dcf18c2

Thanks for the suggestion! Where did you get it?

@nickmoreton
Copy link
Collaborator

Thanks for the suggestion! Where did you get it?

HI @katdom13 Mostly from experience but I new about this here: https://docs.wagtail.org/en/v6.1/advanced_topics/testing.html#fixtures which leads you onto the Django docs.
When I fixed the folder for the dump file I noticed the differences between the original dump file and the new one and thought we wouldn't need the extra data I could see so excluded them until it matched what was in the old one.

Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katdom13 katdom13 merged commit c123bcb into main May 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants