-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 6.1 #17
Wagtail 6.1 #17
Conversation
I had to bump the minimum Wagtail version to 5.2 since older ones have reached EOL. Same for the Django versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katdom13 This all looks good. Just one update looks like is needed on the Makefile
wagtail-django-recaptcha/Makefile
Line 29 in 81fa9f9
python ./tests/testapp/manage.py dumpdata --indent=4 -e contenttypes -e auth.permission -e auth.group -e sessions -e wagtailcore.site -e wagtailcore.pagerevision -e wagtailcore.grouppagepermission -e wagtailimages.rendition -e wagtailcore.collection -e wagtailcore.groupcollectionpermission > tests/testapp/fixtures/test_data.json |
I noticed that running the update-test-fixture
command failed and it was because the fixtures file is in a different location in the home app.
Also the fixtures end up with data that's new in wagtail but isn't excluded.
This should help with modernising it.
update-test-fixture: ## Update test fixture from the db.
python ./tests/testapp/manage.py dumpdata --indent=4 \
-e contenttypes -e auth.permission -e auth.group -e sessions \
-e wagtailcore.site -e wagtailcore.revision -e wagtailcore.grouppagepermission \
-e wagtailimages.rendition -e wagtailcore.collection -e wagtailcore.groupcollectionpermission \
-e wagtailcore.locale \
-e wagtailcore.workflowpage -e wagtailcore.workflowtask -e wagtailcore.task -e wagtailcore.workflow -e wagtailcore.groupapprovaltask \
> tests/testapp/home/fixtures/test_data.json
HI @nickmoreton , Thanks for the suggestion! Where did you get it? |
HI @katdom13 Mostly from experience but I new about this here: https://docs.wagtail.org/en/v6.1/advanced_topics/testing.html#fixtures which leads you onto the Django docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Notes
Wagtail 6.1 upgrade check list
Code reviewing a consideration.
Use the tick box to indicate a consideration has been code reviewed as OK
What’s new
Changes affecting wagtail customizations
Changes to undocumented internals