Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove qs-stringify dependency #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toomuchdesign
Copy link
Owner

What kind of change does this PR introduce?

Refactor

What is the new behaviour?

Generate with native URLSearchParams instead of qs-stringify.

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated

@toomuchdesign
Copy link
Owner Author

Considered creating query strings with URLSearchParams, but learned that browser implementations do more than specs which don't support array of strings.

Therefore leaving this aside for a while since URLSearchParams should work but specs don't say so.

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: ad734db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
next-use-contextual-routing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant