Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap phase node #251

Open
abargerbos opened this issue Dec 23, 2021 · 2 comments
Open

Unwrap phase node #251

abargerbos opened this issue Dec 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@abargerbos
Copy link

Would you be open to an unwrap phase button, perhaps similar to the subtract average node/filter/widget (I'm not sure on the naming)? I can imagine the interface should not get too cluttered, but phase wrapping does come up quite frequently and makes it essentially impossible to look at the data. Or would you say the user should take care of this on their data acquisition end?

@wpfff
Copy link
Contributor

wpfff commented Dec 23, 2021

@abargerbos yes, i think that would be a great addition (even though i do tell my students to always use correct electrical delays in vna measurements, for example ;))
one option would indeed be an additional control like for the average subtraction.
an even better solution would be a more comprehensive filter node that does multiple 'typical' complex data operations (like rotation in iq space, etc).
did you mean to imply that you are willing to give a first prototype a shot? :)
I'm not yet sure when i myself would have the time to implement this, there's a few projects ahead of this on my end.

@abargerbos
Copy link
Author

abargerbos commented Jan 4, 2022

A node like that does sound like it would be very useful! I'm willing to give it a shot (I should be able to get somewhere with the existing code as a template), but I can't yet guarantee when that will be either. To be continued!

@marcosfrenkel marcosfrenkel added the enhancement New feature or request label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants