Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use "similarity" methods over deprecated "distance" methods for rake tasks #56

Conversation

ybiquitous
Copy link
Contributor

This change removes a lot of deprecation warnings from rake compare and rake benchmark executions.

It follows up to the commit d662816 (PR #55).


@tonytonyjan Today, thank you a lot for providing the contribution opportunity in person. I opened this PR because I just noticed my PR (#55) still needed more changes to dismiss the new deprecation warning. But if this is out of your mind, please don't hesitate to close it. 😊 👍🏼

…r rake tasks

This change removes a lot of deprecation warnings from `rake compare` and `rake benchmark` executions.

It follows up to the commit:
tonytonyjan@d662816
Copy link
Owner

@tonytonyjan tonytonyjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the change looks good to me 🙌

@tonytonyjan tonytonyjan merged commit ec51b6e into tonytonyjan:master Aug 28, 2024
30 checks passed
@ybiquitous ybiquitous deleted the remove-deprecation-warnings-from-rakefile-and-benchmark branch August 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants