Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README example with asyncio.run #348

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

PaarthShah
Copy link
Contributor

asyncio.run is the current, documented method to begin and clean up an async event loop, as of python3.7.

python3.9 is the oldest version of python that isn't EOL.

[asyncio.run](https://docs.python.org/3/library/asyncio-runner.html#asyncio.run) is the current, documented method to begin and clean up an async event loop, as of python3.7.

python3.9 is the oldest version of python that isn't EOL.
Copy link
Owner

@tomplus tomplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tomplus tomplus merged commit 1504929 into tomplus:master Feb 5, 2025
4 of 5 checks passed
@PaarthShah PaarthShah deleted the patch-1 branch February 5, 2025 22:01
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.05%. Comparing base (f1d47ed) to head (bb78715).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   27.05%   27.05%           
=======================================
  Files         805      805           
  Lines       98706    98706           
=======================================
  Hits        26704    26704           
  Misses      72002    72002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants