Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auctex-latexmk.el #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wang1zhen
Copy link

tex-buf is no longer provided by the auctex package.

Comment on lines 57 to 58
(unless (string-prefix-p "13" AUCTeX-version)
(require 'tex-buf))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if AUCTeX is not yet loaded? AUCTeX-version will be undefined in that case, right?

How about:

(unless (require 'tex-buf nil t)
  (require 'tex))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As latex.el should be loaded anyway, I think we shall try to load latex.el first, then load the tex-buf.el according to the version of auctex

Copy link

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this PR makes the package work again.

@tobiasBora
Copy link

Any news on this?

@tarsius
Copy link

tarsius commented Sep 29, 2022

@tom-tan Friendly ping!

tarsius added a commit to emacsmirror/auctex-latexmk that referenced this pull request Oct 25, 2022
In auctex tex-buf.el was merged into tex.el, see
emacsmirror/auctex@4b1c7015ae77b.

Continue to soft-require it for users who still use an old
version of auctex.

The upstream issue is tom-tan#44.
There also is a pr; tom-tan#40.

[Emacsmirror] This commit is being rebased onto upstream.
tarsius added a commit to melpa/melpa that referenced this pull request Oct 25, 2022
The upstream version is broken and the maintainer does not respond.
See tom-tan/auctex-latexmk#40.

The version on the Emacsmirror comes with a patch that fixes this
issue.  There's also an additional tag, so that the issue is also
fixed for Melpa Stable.
@tarsius
Copy link

tarsius commented Oct 25, 2022

I have added a patch to the version on the Emacsmirror to fix this issue, and have updated Melpa to get this package from there.

basil-conto added a commit to basil-conto/dotfiles that referenced this pull request Oct 26, 2022
This reverts commit e863fbe
"[EMACS] Reconcile auctex-latexmk with new AUCTeX".

See tom-tan/auctex-latexmk#40.
akirak pushed a commit to akirak/melpa that referenced this pull request Jul 8, 2023
The upstream version is broken and the maintainer does not respond.
See tom-tan/auctex-latexmk#40.

The version on the Emacsmirror comes with a patch that fixes this
issue.  There's also an additional tag, so that the issue is also
fixed for Melpa Stable.
@dr-scsi
Copy link

dr-scsi commented Jun 29, 2024

@tarsius - AUCTeX now has built-in support for LaTeXmk added with this commit. Maybe it makes sense to archive this repo and the one from Emacsmirror and tell users to update their AUCTeX installations. Bug reports etc. can be addressed to the AUCTeX team. WDYT?

@tarsius
Copy link

tarsius commented Jun 29, 2024

Probably. Have you (or any of the numerous users who up-thumbed earlier) checked whether the built-in support handles everything the old package handled? If I don't hear about any issues, I'll remove this package in a week or so.

@dr-scsi
Copy link

dr-scsi commented Jun 29, 2024

@tarsius - I've never used auctex-latexmk.el, so I can't tell. From reading the code, AUCTeX lacks the encoding magic this library does (AUCTeX has a different approach); the plain LaTeXMk support should be better integrated in AUCTeX and the variables it provides for controlling the output.

We can try to formalize this process a little by opening a new bug-report here (I'll do it) and try to get answers to your questions from the actual users. If we're lucky, @tom-tan chimes in and we clarify things.

@basil-conto
Copy link

basil-conto commented Jun 29, 2024

The AUCTeX changes also come with the following announcement in NEWS.org:

  • Add preliminary support for processing files with latexmk. Support
    for dvipdfmx and the choice for viewer after compilation are not
    optimal, yet. Overall, the support comes close to what the
    auctex-latexmk library provides.

@basil-conto
Copy link

Have you (or any of the numerous users who up-thumbed earlier) checked whether the built-in support handles everything the old package handled?

One minor thing I've noticed in my own workflow, but haven't had time to report or look into:

I add the function TeX-revert-document-buffer to the hook TeX-after-compilation-finished-functions so that the PDF-visiting buffer is reverted after each (manually invoked) recompilation, as documented under (info "(auctex) Modes and Hooks").

AFAICT this hook is not run by AUCTeX's built-in "LaTeXMk" command, since it invokes TeX-run-format (instead of TeX-run-TeX or similar, as the "LaTeX" command does).

My current workaround involves advising TeX-TeX-sentinel to run the hook.

@dr-scsi
Copy link

dr-scsi commented Jul 5, 2024

@basil-conto - Thanks for raising this. Can you please file a bug report to the AUCTeX tracker? The address is bug-auctex@gnu.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants