-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auctex-latexmk.el #40
base: master
Are you sure you want to change the base?
Conversation
auctex-latexmk.el
Outdated
(unless (string-prefix-p "13" AUCTeX-version) | ||
(require 'tex-buf)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if AUCTeX is not yet loaded? AUCTeX-version
will be undefined in that case, right?
How about:
(unless (require 'tex-buf nil t)
(require 'tex))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As latex.el
should be loaded anyway, I think we shall try to load latex.el
first, then load the tex-buf.el
according to the version of auctex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this PR makes the package work again.
Any news on this? |
@tom-tan Friendly ping! |
In auctex tex-buf.el was merged into tex.el, see emacsmirror/auctex@4b1c7015ae77b. Continue to soft-require it for users who still use an old version of auctex. The upstream issue is tom-tan#44. There also is a pr; tom-tan#40. [Emacsmirror] This commit is being rebased onto upstream.
The upstream version is broken and the maintainer does not respond. See tom-tan/auctex-latexmk#40. The version on the Emacsmirror comes with a patch that fixes this issue. There's also an additional tag, so that the issue is also fixed for Melpa Stable.
I have added a patch to the version on the Emacsmirror to fix this issue, and have updated Melpa to get this package from there. |
This reverts commit e863fbe "[EMACS] Reconcile auctex-latexmk with new AUCTeX". See tom-tan/auctex-latexmk#40.
The upstream version is broken and the maintainer does not respond. See tom-tan/auctex-latexmk#40. The version on the Emacsmirror comes with a patch that fixes this issue. There's also an additional tag, so that the issue is also fixed for Melpa Stable.
@tarsius - AUCTeX now has built-in support for LaTeXmk added with this commit. Maybe it makes sense to archive this repo and the one from Emacsmirror and tell users to update their AUCTeX installations. Bug reports etc. can be addressed to the AUCTeX team. WDYT? |
Probably. Have you (or any of the numerous users who up-thumbed earlier) checked whether the built-in support handles everything the old package handled? If I don't hear about any issues, I'll remove this package in a week or so. |
@tarsius - I've never used We can try to formalize this process a little by opening a new bug-report here (I'll do it) and try to get answers to your questions from the actual users. If we're lucky, @tom-tan chimes in and we clarify things. |
The AUCTeX changes also come with the following announcement in
|
One minor thing I've noticed in my own workflow, but haven't had time to report or look into: I add the function AFAICT this hook is not run by AUCTeX's built-in "LaTeXMk" command, since it invokes My current workaround involves advising |
@basil-conto - Thanks for raising this. Can you please file a bug report to the AUCTeX tracker? The address is bug-auctex@gnu.org. |
tex-buf is no longer provided by the auctex package.