Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect architecture and give error if running on reMarkable paper pro #933

Merged
merged 4 commits into from
Jan 5, 2025

Conversation

xugro
Copy link

@xugro xugro commented Dec 21, 2024

Added some groundwork to the installation script for supporting rmpp.
It just quits installation if run on aarch64.

@Eeems
Copy link
Member

Eeems commented Dec 21, 2024

We do have code in toltecctl that would reject the rMPP, but we probably would need to rejig rmall to move all the non-architecture-independent packages to a different repo.

@xugro
Copy link
Author

xugro commented Dec 22, 2024

We do have code in toltecctl that would reject the rMPP, but we probably would need to rejig rmall to move all the non-architecture-independent packages to a different repo.

My main reason for detecting rmpp within the installation script was to download the correct wget binary for the device as the architecture is different. The rest can be handled by toltec which has existing mechanisms to do so anyways.

@Eeems
Copy link
Member

Eeems commented Jan 5, 2025

We do have code in toltecctl that would reject the rMPP, but we probably would need to rejig rmall to move all the non-architecture-independent packages to a different repo.

My main reason for detecting rmpp within the installation script was to download the correct wget binary for the device as the architecture is different. The rest can be handled by toltec which has existing mechanisms to do so anyways.

Fair enough, I have been thinking about this and I don't think there is a way around duplicating the code instead of sharing it between bootstrap and toltecctl.

I've updated the PR to go back to rmall, and commented out the rMPP architecture handling for now. Followup tasks will be to create a static compile of wget for the architecture, and then make sure rmall is properly architecture independent, and create new repos for architecture specific packages.

@Eeems Eeems added this to the 2024-W51 Merge Window milestone Jan 5, 2025
@Eeems Eeems merged commit 259b413 into toltec-dev:testing Jan 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants