This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Add setup and tear down logic #60
Open
polina-popova
wants to merge
5
commits into
master
Choose a base branch
from
replace_func_by_api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98dc7db
to
08e2f98
Compare
2f16794
to
a9821f8
Compare
40b77e3
to
fed6749
Compare
eugulixes
reviewed
Feb 12, 2019
eugulixes
reviewed
Feb 12, 2019
eugulixes
reviewed
Feb 12, 2019
eugulixes
reviewed
Feb 12, 2019
eugulixes
reviewed
Feb 12, 2019
eugulixes
reviewed
Feb 12, 2019
de56696
to
9516951
Compare
ya7on
reviewed
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After tear down in terminal is written some tracebacks
02/14/2019 11:29:29 AM Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f85fad14ac8>: Failed to establish a new connection: [Errno 111] Connection refused')': /session/***
02/14/2019 11:29:29 AM Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f85fad14cf8>: Failed to establish a new connection: [Errno 111] Connection refused')': /session/***
02/14/2019 11:29:29 AM Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f85fad14860>: Failed to establish a new connection: [Errno 111] Connection refused')': /session/***
Need to remove create_test_user=False from vote_or_die_script_tests.py: |
ya7on
reviewed
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to catch exception when RocketChat API is not logged in
9516951
to
c9bd362
Compare
polina-popova
commented
Feb 20, 2019
008f919
to
10ad573
Compare
eb112b8
to
f965611
Compare
f965611
to
5ccd08e
Compare
ya7on
suggested changes
Mar 11, 2019
ya7on
suggested changes
Mar 11, 2019
2608439
to
5b6706d
Compare
1a4d2e4
to
617f8b9
Compare
681aee8
to
d6424ae
Compare
eugulixes
reviewed
Apr 5, 2019
happy_birthder_script_tests.py
Outdated
@@ -87,6 +92,27 @@ def _wait_reminder(self): | |||
# Public methods | |||
# | |||
|
|||
def tear_down(self): | |||
"""Makes clean up of the testing enviroment. """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There is a typo in
enviroment
. - Let's rewrite the docstring:
Cleans up the testing environment
c213b58
to
c1345d3
Compare
c1345d3
to
df0b072
Compare
d432eb0
to
e02ed3f
Compare
e02ed3f
to
1342b97
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53