Update sdk to v2 #3207

roppazvan · 2024-11-22T15:17:05Z

Why does this PR exist?

This updates the studio sync provider to use the latest SDK version.

What does this pull request do?

Testing this change

Run graphql locally. Add the local endpoint in the plugin env variables.

Additional Notes (if any)

changeset-bot · 2024-11-22T15:17:10Z

🦋 Changeset detected

Latest commit: 9a748e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tokens-studio/figma-plugin	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-11-22T15:20:08Z

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

github-advanced-security

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx

packages/tokens-studio-for-figma/src/app/components/modals/DuplicateTokenGroupModal.test.tsx

packages/tokens-studio-for-figma/src/app/components/modals/RenameTokenGroupModal.test.tsx

packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts

+      successCallback?.();
+    } catch (e) {
+      Sentry.captureException(e);
+      console.error('Error updating token set order in Tokens Studio', e);


packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts

+      successCallback?.();
+    } catch (e) {
+      Sentry.captureException(e);
+      console.error('Error creating theme group in Tokens Studio', e);


packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts

+      successCallback?.();
+    } catch (e) {
+      Sentry.captureException(e);
+      console.error('Error updating theme group in Tokens Studio', e);


packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts

+      successCallback?.();
+    } catch (e) {
+      Sentry.captureException(e);
+      console.error('Error deleting theme group in Tokens Studio', e);


packages/tokens-studio-for-figma/src/utils/convert.ts

packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx

github-actions · 2024-12-09T11:08:38Z

Commit SHA:8e3bc5ae9affbddb72787a2846501cfe2d5072c9

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: update-sdk-to-v2

Status	File	% Stmts	% Branch	% Funcs	% Lines
🔴	total	67.08 (0.01)	57.85 (-0.09)	63.86 (-0.04)	67.45 (0.03)
🔴	packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx	1.81 (-2.95)	0 (0)	0 (0)	2.12 (-2.88)
🔴	packages/tokens-studio-for-figma/src/app/store/models/tokenState.tsx	76.44 (-0.54)	63.07 (-1.09)	84 (0.5)	76.51 (-0.24)
🟢	packages/tokens-studio-for-figma/src/app/store/models/reducers/tokenState/disconnectStyleFromTheme.ts	78.57 (1.65)	80 (5)	50 (0)	76.92 (1.92)
🟢	packages/tokens-studio-for-figma/src/app/store/providers/tokens-studio/tokensStudio.tsx	34.28 (5.71)	8.33 (8.33)	44.44 (6.94)	34.28 (5.71)
🔴	packages/tokens-studio-for-figma/src/app/store/utils/updateAliasesInState.ts	82.85 (-6.62)	70 (-30)	100 (0)	90 (0.53)
🟢	packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts	50.31 (2.87)	34.84 (-4.33)	52.17 (36.79)	51.28 (2.85)
🔴	packages/tokens-studio-for-figma/src/storage/tokensStudio/createTokenInTokensStudio.ts	85.71 (-14.29)	50 (-50)	100 (0)	85.71 (-14.29)
🟢	packages/tokens-studio-for-figma/src/storage/tokensStudio/createTokenSetInTokensStudio.ts	100 (0)	100 (25)	100 (0)	100 (0)
🟢	packages/tokens-studio-for-figma/src/storage/tokensStudio/deleteTokenSetFromTokensStudio.ts	100 (0)	100 (50)	100 (0)	100 (0)
✨ 🆕	packages/tokens-studio-for-figma/src/storage/tokensStudio/duplicateTokenInTokensStudio.ts	0	100	0	0
🟢	packages/tokens-studio-for-figma/src/storage/tokensStudio/updateTokenSetInTokensStudio.ts	100 (0)	100 (25)	100 (0)	100 (0)
✨ 🆕	packages/tokens-studio-for-figma/src/storage/tokensStudio/graphql/getOrgsQuery.ts	100	100	100	100
🔴	packages/tokens-studio-for-figma/src/storage/tokensStudio/updateThemeGroupsInTokensStudio/getThemeGroupsToUpdate.ts	100 (0)	75 (-8.33)	100 (0)	100 (0)
🔴	packages/tokens-studio-for-figma/src/storage/tokensStudio/updateThemeGroupsInTokensStudio/index.ts	83.33 (-5.37)	43.75 (-28.25)	100 (0)	83.33 (-5.19)
🔴	packages/tokens-studio-for-figma/src/storage/tokensStudio/updateThemeGroupsInTokensStudio/saveTheme.ts	91.42 (-5.35)	77.27 (-2.73)	100 (0)	91.17 (-4.83)
✨ 🆕	packages/tokens-studio-for-figma/src/utils/convert.ts	100	40	100	100
🔴	packages/tokens-studio-for-figma/src/utils/themeListToTree.ts	63.63 (0)	46.42 (0)	50 (0)	63.63 (-14.14)
🔴	packages/tokens-studio-for-figma/src/utils/tokenHelpers.ts	53.33 (0)	57.69 (0)	41.66 (0)	53.84 (-6.16)
❌	~~packages/tokens-studio-for-figma/src/storage/tokensStudio/utils/tokensStudioToToken.ts~~	~~10.34~~	0	0	~~11.11~~

github-actions · 2024-12-09T11:08:39Z

Commit SHA:8e3bc5ae9affbddb72787a2846501cfe2d5072c9
Current PR reduces the test coverage percentage by 1 for some tests

six7

It'd have been easier if formatting changes were not part of that PR. Also, it had gotten super big, it might have made sense to break it down in smaller PRs.

six7 · 2024-12-09T20:45:32Z

packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx

+  const fetchOrgData = React.useCallback(async () => {
+    try {
+      const client = create({
+        host: process.env.API_HOST || 'localhost:4200',


Is this the Studio API? Lets change the name of the env variable then to Studio

six7 · 2024-12-09T20:46:01Z

packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx

+        setOrgData(result.data.organizations.data as Organization[]);
+      }
+    } catch (error) {
+      setFetchOrgsError('Error fetching organization data. Please check your PAT.');


Lets write the full name not PAT

six7 · 2024-12-09T20:49:28Z

...ens-studio-for-figma/src/app/store/models/reducers/tokenState/renameVariableNamesToThemes.ts

@@ -7,7 +7,7 @@ export function renameVariableNamesToThemes(state: TokenState, tokensToRename: T
    return acc;
  }, {});
  const newThemes = state.themes.map((theme) => {
-    const updatedTokens = theme.$figmaVariableReferences;
+    const updatedTokens = { ...theme.$figmaVariableReferences };


Why are we doing it that way?

reverted this change as it was causing issues with tests.

six7 · 2024-12-09T20:58:12Z

packages/tokens-studio-for-figma/src/app/store/utils/updateAliasesInState.test.ts


-    expect(updatedTokens).toEqual(expectedTokens);
+    expect(newTokens).toEqual(expectedTokens);


Is this on purpose?

six7 · 2024-12-09T20:58:38Z

packages/tokens-studio-for-figma/src/app/store/utils/updateAliasesInState.test.ts


-    expect(updatedTokens).toEqual(expectedTokens);
+    expect(newTokens).toEqual(expectedTokens);


Is this on purpose? We used to check for updated tokens now were doing new tokens?

just renamed it, but reverted back. updatedTokens is better.

six7 · 2024-12-09T21:09:27Z

packages/tokens-studio-for-figma/src/utils/themeListToTree.ts

      acc.splice(parentIndex + childrenLength + 1, 0, {
        isLeaf: true,
        value: curr,
-        key: curr.id,
+        key: curr.name,


Is this a fn just used by Studio?

it's used by the manage themes modal

i think same as before, name is not unique

six7 · 2024-12-09T21:10:04Z

packages/tokens-studio-for-figma/src/utils/tokenHelpers.ts


 export function getOverallConfig(themes: ThemeObject[], selectedThemes: string[]) {
  return selectedThemes.reduce((acc, themeId) => {
-    const currentTheme = themes.find((theme) => theme.id === themeId);
+    const currentTheme = themes.find((theme) => theme.name === themeId);


Why are we switching from id to name?

this was done before we moved everything to postgres . The idea was that gitea would be name based. Most of the studio stuff is the same. everything is based on name, except project and org.

@roppazvan i think we cannot compare name.. there could be multiple themes with the same name (under different groups), lets keep to id

six7

approving code-side, @rbosker @keeganedwin can you do functional testing?

keeganedwin · 2024-12-17T10:24:54Z

approving code-side, @rbosker @keeganedwin can you do functional testing?
Test was successful. Was able to :

Choose Org
Choose Proj
Export styles & variables

roppazvan added 5 commits November 20, 2024 15:48

changes

18dc85d

set reorde & sync to studio

d21cc18

rm logs and fetch org data on mount

c07757c

rm logs

741e57c

rm logs

25cb6ab

github-advanced-security bot found potential problems Nov 22, 2024

View reviewed changes

georgebuciuman and others added 5 commits November 25, 2024 11:04

Fix themes - create, delete and partial update

848a986

Merge branch 'main' into update-sdk-to-v2

0265d9e

Themes fixes + waterfall requests to studio

c09038b

cleanunp

32dd5a9

lint

4370c40

github-advanced-security bot found potential problems Nov 28, 2024

View reviewed changes

fix lint

456179f

github-advanced-security bot found potential problems Nov 28, 2024

View reviewed changes

packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx Fixed Show fixed Hide fixed

packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx Fixed Show fixed Hide fixed

lint

9f325bb

roppazvan marked this pull request as ready for review November 28, 2024 14:32

roppazvan requested review from six7 and SorsOps November 28, 2024 14:33

Fix tests

713c5f0

six7 added the do not merge Not ready for merging yet label Dec 9, 2024

roppazvan added 5 commits December 9, 2024 11:01

Merge branch 'main' into update-sdk-to-v2

6ddf15d

fix lint

a42b01c

fix build

e891a1d

fix build

0ec98d6

fix tests

e822c5e

roppazvan requested a review from akshay-gupta7 December 9, 2024 11:58

rbosker added the sync tokens studio (beta) label Dec 9, 2024

six7 reviewed Dec 9, 2024

View reviewed changes

roppazvan and others added 3 commits December 12, 2024 12:07

requested changes

5b45ab4

Merge branch 'main' into update-sdk-to-v2

5d5fab9

fix id issue

d9e0bd5

roppazvan requested a review from six7 December 16, 2024 13:56

six7 approved these changes Dec 17, 2024

View reviewed changes

roppazvan added 2 commits December 18, 2024 13:21

add changeset

8cbef62

updated changeset

9a748e3

roppazvan merged commit da1786c into main Dec 18, 2024
9 of 10 checks passed

roppazvan deleted the update-sdk-to-v2 branch December 18, 2024 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sdk to v2 #3207

Update sdk to v2 #3207

roppazvan commented Nov 22, 2024 •

edited

Loading

changeset-bot bot commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 22, 2024 •

edited

Loading

github-advanced-security bot left a comment

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

six7 left a comment

six7 Dec 9, 2024

roppazvan Dec 12, 2024

six7 Dec 9, 2024

roppazvan Dec 12, 2024

six7 Dec 9, 2024

roppazvan Dec 12, 2024

six7 Dec 9, 2024

six7 Dec 9, 2024

roppazvan Dec 12, 2024

six7 Dec 9, 2024

roppazvan Dec 12, 2024

six7 Dec 16, 2024

six7 Dec 9, 2024

roppazvan Dec 12, 2024

six7 Dec 16, 2024

six7 left a comment

keeganedwin commented Dec 17, 2024


		expect(updatedTokens).toEqual(expectedTokens);
		expect(newTokens).toEqual(expectedTokens);

Update sdk to v2 #3207

Update sdk to v2 #3207

Conversation

roppazvan commented Nov 22, 2024 • edited Loading

Why does this PR exist?

What does this pull request do?

Testing this change

Additional Notes (if any)

changeset-bot bot commented Nov 22, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Nov 22, 2024 • edited Loading

github-advanced-security bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024 • edited Loading

Test coverage results 🧪

github-actions bot commented Dec 9, 2024 • edited Loading

six7 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

six7 left a comment

Choose a reason for hiding this comment

keeganedwin commented Dec 17, 2024

roppazvan commented Nov 22, 2024 •

edited

Loading

changeset-bot bot commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading