feat: introduce simple migration framework #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
benfdking
commented
Jan 13, 2025
benfdking
commented
- introduces simple migration framework to make it possible to change tables later down the lline
izeigerman
reviewed
Jan 14, 2025
saq/queue/postgres.py
Outdated
| jobs_table=self.jobs_table, | ||
| stats_table=self.stats_table, | ||
| ) | ||
| target_number = len(migrations) |
There was a problem hiding this comment.
don't use len(...), let's use the file number
izeigerman
reviewed
Jan 14, 2025
izeigerman
reviewed
Jan 14, 2025
izeigerman
reviewed
Jan 14, 2025
izeigerman
reviewed
Jan 14, 2025
izeigerman
reviewed
Jan 14, 2025
benfdking
force-pushed
the
benfdking/adding_queue_system
branch
4 times, most recently
from
ba27441 to
a9b90a1
Compare
tobymao
reviewed
Jan 14, 2025
saq/queue/postgres.py
Outdated
| jobs_table=self.jobs_table, | ||
| stats_table=self.stats_table, | ||
| ) | ||
| target_version = len(migrations) |
There was a problem hiding this comment.
let's get the last one, and infer the version from the file name
There was a problem hiding this comment.
can we make this either a hash value or something less error prone? or perhaps like manual tagging of versions
There was a problem hiding this comment.
I don't think we can do hash cause we need to have total order
There was a problem hiding this comment.
he's gonna change it to be manual indices
benfdking
force-pushed
the
benfdking/adding_queue_system
branch
from
a9b90a1 to
9a3ba91
Compare
izeigerman
approved these changes
Jan 15, 2025
tobymao
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.