Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing white space #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pulledtim
Copy link

Currently no whitespace is in front of the secret, which results in an helm error

@tmaier
Copy link
Owner

tmaier commented Oct 8, 2019

A Password with whitespace? Is this a real problem? What are the conventions at other helm charts?

@pulledtim
Copy link
Author

Ok a little missunderstanding. The generated secrets yaml will have no whitespace between MONGODB_PASSWORD: and the password. Resulting in this error
Error: YAML parse error on errbit-helm/templates/secret.yaml: error converting YAML to JSON: yaml: line 14: could not find expected ':'

@pulledtim
Copy link
Author

I also updated the Dockerfile. The current version of the errbit container does not have the user errbit anymore -> errbit/errbit#1275
I hope you are ok with me adding a fixed version of the errbit container, since I think it helps with making the build reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants