feat(nav): status text & icon #1772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alanzhu0
requested changes
Apr 27, 2025
There was a problem hiding this comment.
Looks good! I think the only thing is, I think it would be better if the icons were kept consistent between the desktop and mobile versions (and the mobile ones with nav closed). It would be clearer I think to use either the betteruptime icons in all cases, or these circles in all cases
| margin-left: 5px; | ||
| display: inline; | ||
|
|
||
| background: linear-gradient( |
alanzhu0
requested changes
May 4, 2025
There was a problem hiding this comment.
Looking good! I like the color. Just some very small things: (1) can you make it so when the text in the navbar is clicked it goes to the status page? (2) the icon in the header on mobile just looks a tiny bit out of line with the three bars for opening the navbar, could it be moved a tiny bit? A bit down maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Brief description of rationale