Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a contributing.md file and added content to it #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Chukwuneme
Copy link
Contributor

I created a contributing.md file, added the readme content to it while editing some grammar. Then I added some template contribution documentation.

First contribution to an open-source project. Hope it gets merged :)

@netlify
Copy link

netlify bot commented Oct 29, 2022

Deploy Preview for techtalk7 ready!

Name Link
🔨 Latest commit 30d84c9
🔍 Latest deploy log https://app.netlify.com/sites/techtalk7/deploys/635d4133635bc5000805b223
😎 Deploy Preview https://deploy-preview-28--techtalk7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@timokonkwo timokonkwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution. I like that.

I see you added descriptions of tech talk inside the contributing.md. It should rather be in the repo readme.

Also, Code Of Conduct.md is different from Contributing.md

I see you added the code of conduct inside the contributing.md

Please do separate it to its own md file and create another PR

Also, Please note that the Readme.md of the profile will have to change. It should contain descriptions of tech talk, the information that is linking to the contributing.md e.g "see contributing.md for guideline on how to contribute". The readme should also contain a link to the code of conduct.md file

You can refer to the example repos given in the issue for inspiration

Please effect this changes and create another PR. Thank you

@timokonkwo timokonkwo added the duplicate This issue or pull request already exists label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants