check / install python version using pyenv #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry asking you to check code style. I can add some tests. |
|
a lot more code than I was expecting ;-) |
kthhrv
reviewed
Mar 31, 2023
timeout_tools/cli.py
Outdated
| if status: | ||
| raise BaseException(f'Failed to install python version {python_version}') | ||
| else: | ||
| print(f'- Python `{python_version}` installation successful ✅') |
There was a problem hiding this comment.
the first part of the message should print before the installs start and the tick be added when in succeeds
kthhrv
reviewed
Mar 31, 2023
| @@ -158,9 +162,13 @@ def python_setup_func(args): | |||
|
|
|||
|
|
|||
| def python_setup(app, branch, python_version): | |||
| try: | |||
| check_python_version_installed(python_version) | |||
There was a problem hiding this comment.
I feel the logic shouldn't be inside the check function, ie if the check returns false here then call the install here
There was a problem hiding this comment.
certainly makes the tests easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the correct version of Python is installed and managed by Pyenv
If version is not installed attempts to install using pyenv
If version is not available prompts user to update pyenv