Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix default log file size #9038

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 6, 2025

What problem does this PR solve?

Issue Number: Close #9037

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (dcb426b) to head (2b01efc).
Report is 1429 commits behind head on master.

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9038      +/-   ##
==========================================
+ Coverage   75.54%   76.29%   +0.75%     
==========================================
  Files         332      467     +135     
  Lines       33892    71113   +37221     
==========================================
+ Hits        25604    54259   +28655     
- Misses       6082    13479    +7397     
- Partials     2206     3375    +1169     
Flag Coverage Δ
unittests 76.29% <60.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 12:26:23.920042375 +0000 UTC m=+361055.452454358: ☑️ agreed by JmPotato.
  • 2025-02-07 03:13:11.868268892 +0000 UTC m=+414263.400680875: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 0c43ce5 into tikv:master Feb 7, 2025
24 of 26 checks passed
@rleungx rleungx deleted the fix-log-size branch February 7, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default max-size of log file is changed
3 participants