Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Go runtime metrics #8927

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Metrics: Go runtime metrics #8927

merged 10 commits into from
Dec 19, 2024

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Dec 17, 2024

What problem does this PR solve?

Issue Number: Close #8931

What is changed and how does it work?

Using promtheus clieng golang mod to expose go runtime metrics.
how to see this:

tiup playground nightly --pd.mode ms --tiflash 0 --kv 3 --pd 1 --db 1 --tso 2 --scheduling 1 --tso.binpath ./bin/pd-server --scheduling.binpath ./bin/pd-server --pd.binpath ./bin/pd-server

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

image
image

Code changes

Side effects

Related changes

Release note

expose golang runtime metrics 

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 17, 2024
Signed-off-by: bufferflies <1045931706@qq.com>
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (da4b43a) to head (1e2b369).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8927      +/-   ##
==========================================
- Coverage   76.29%   76.25%   -0.04%     
==========================================
  Files         462      462              
  Lines       70429    70436       +7     
==========================================
- Hits        53735    53714      -21     
- Misses      13346    13369      +23     
- Partials     3348     3353       +5     
Flag Coverage Δ
unittests 76.25% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 18, 2024
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2024
@bufferflies bufferflies marked this pull request as ready for review December 18, 2024 07:42
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@bufferflies bufferflies changed the title Go runtime metrics Metrics: Go runtime metrics Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-18 11:12:15.673006222 +0000 UTC m=+1041725.761808764: ☑️ agreed by nolouch.
  • 2024-12-19 03:00:08.917411499 +0000 UTC m=+1098599.006214043: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit ac59675 into tikv:master Dec 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd support to report runtime metrics to prometheues
3 participants