scheduler: support changing batch for slow score scheduler #8888
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
dco-signoff: yes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8888 +/- ##
==========================================
- Coverage 76.30% 76.27% -0.04%
==========================================
Files 465 465
Lines 70659 70682 +23
==========================================
- Hits 53916 53911 -5
- Misses 13395 13410 +15
- Partials 3348 3361 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/retest |
1 similar comment
|
/retest |
rleungx
force-pushed
the
batch-evict-slow
branch
from
a6d91be to
84eb725
Compare
|
/cc @LykxSassinator |
|
@rleungx: GitHub didn't allow me to request PR reviews from the following users: LykxSassinator. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -49,6 +49,7 @@ type evictSlowStoreSchedulerConfig struct { | |||
| // Duration gap for recovering the candidate, unit: s. | |||
| RecoveryDurationGap uint64 `json:"recovery-duration"` | |||
| EvictedStores []uint64 `json:"evict-stores"` | |||
| Batch int `json:"batch"` | |||
There was a problem hiding this comment.
Should we add a TODO note here, reminding that this PR might also need to be applied to evict-slow-trend-scheduler in future work if necessary?
rleungx
force-pushed
the
batch-evict-slow
branch
from
84eb725 to
02ea6ec
Compare
|
@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
@okJiang PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, LykxSassinator, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #7156
What is changed and how does it work?
After this PR, we can change the batch size through pd-ctl:
Check List
Tests
Release note