Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server, metrics: let server TSO handle duration including failed requests #8282

Merged
merged 1 commit into from
Jun 13, 2024
Merged

server, metrics: let server TSO handle duration including failed requests #8282

merged 1 commit into from
Jun 13, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jun 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8281.

What is changed and how does it work?

- Delete the 99.999% percentile data because it does not correspond with TiDB and is too tail-end, which can easily mislead.
- Emphasize PD server/client in the panel title.
- Add corresponding 90/99/99.9% percentile data on the client handle duration for easier comparison.
- The PD server TSO handle duration now includes the failed requests, directly reflecting TSO HA anomalies in the monitoring data.

Check List

Tests

  • Unit test
  • Integration test
  • Mannual test
image

Release note

Let PD server TSO handle duration including failed requests.

@JmPotato JmPotato added component/metrics Metrics. component/tso Timestamp Oracle. labels Jun 13, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2024
@JmPotato JmPotato force-pushed the record_tso_error_duration branch from 969adfa to 152f262 Compare June 13, 2024 04:03
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2024
@JmPotato JmPotato force-pushed the record_tso_error_duration branch from 152f262 to 00b6aa7 Compare June 13, 2024 04:04
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 13, 2024
@JmPotato
Let server TSO handle duration including failed requests
1f8826f 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the record_tso_error_duration branch from 00b6aa7 to 1f8826f Compare June 13, 2024 05:44
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (c75e98b) to head (00b6aa7).

❗ Current head 00b6aa7 differs from pull request most recent head 1f8826f

Please upload reports for the commit 1f8826f to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8282      +/-   ##
==========================================
+ Coverage   77.27%   77.31%   +0.03%     
==========================================
  Files         471      471              
  Lines       61395    61395              
==========================================
+ Hits        47446    47466      +20     
+ Misses      10395    10378      -17     
+ Partials     3554     3551       -3
Flag Coverage Δ
unittests 77.31% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2024
AndreMouche
AndreMouche approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreMouche, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AndreMouche,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-13 04:04:55.250289004 +0000 UTC m=+610249.303600927: ☑️ agreed by rleungx.
  • 2024-06-13 06:43:58.541027677 +0000 UTC m=+619792.594339587: ☑️ agreed by AndreMouche.

@ti-chi-bot ti-chi-bot bot merged commit e52f5be into tikv:master Jun 13, 2024
16 checks passed
@JmPotato
Copy link
Member Author

/merge

@JmPotato JmPotato deleted the record_tso_error_duration branch June 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved component/metrics Metrics. component/tso Timestamp Oracle. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @AndreMouche @rleungx