-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: fix datarace in operator.check
#8264
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8264 +/- ##
==========================================
+ Coverage 77.32% 77.50% +0.18%
==========================================
Files 471 471
Lines 61380 61381 +1
==========================================
+ Hits 47463 47575 +112
+ Misses 10365 10258 -107
+ Partials 3552 3548 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
startTime, _ := o.getCurrentTimeAndStep() | ||
operatorStepDuration.WithLabelValues(reflect.TypeOf(o.steps[int(step)]).Name()). | ||
Observe(time.Unix(0, o.stepsTime[step]).Sub(startTime).Seconds()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is stepsTime useless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the code goes into this branch, it means that o.stepsTime[step])
is now time.Now()
@okJiang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
please add affect label |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 849163a
|
In response to a cherrypick label: new pull request created to branch |
close tikv#8263 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>
close #8263 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>
In response to a cherrypick label: new pull request created to branch |
close #8263 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
In response to a cherrypick label: new pull request created to branch |
close tikv#8263 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
close tikv#8263 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
close tikv#8263 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
close #8263 Signed-off-by: husharp <ihusharp@gmail.com> Co-authored-by: husharp <ihusharp@gmail.com> Co-authored-by: Hu# <ihusharp@gmail.com>
close #8263 Signed-off-by: husharp <ihusharp@gmail.com> Co-authored-by: husharp <ihusharp@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Close #8263
What is changed and how does it work?
Check List
Tests
go test -timeout 120s -run ^TestOperatorCheckConcurrently$ github.com/tikv/pd/pkg/schedule/operator -race
Release note