Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/tso: improve the switching of TSO stream #8123

Merged
merged 7 commits into from
Apr 28, 2024
Merged

client/tso: improve the switching of TSO stream #8123

merged 7 commits into from
Apr 28, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #7997, ref #8047.

What is changed and how does it work?

Previously, without enabling the TSO Follower Proxy, we only passively update its stream when a TSO request fails.
This means that we cannot automatically and gradually complete the TSO stream update after a service switch.
This PR strengthens this logic, which can improve the success rate of TSO requests during service switching.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Apr 24, 2024
@JmPotato JmPotato requested review from nolouch and rleungx April 24, 2024 09:42
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2024
rleungx
rleungx reviewed Apr 25, 2024
View reviewed changes
client/tso_dispatcher.go
// Only the Global TSO needs to watch the updateTSOConnectionCtxsCh to sense the
// change of the cluster when TSO Follower Proxy is enabled.
// TODO: support TSO Follower Proxy for the Local TSO.
if dc == globalDCLocation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, this goroutine is only used to check the connection updating when the TSO Follower Proxy is enabled for the global DC location. This PR makes it a permanent daemon to update the connection regularly.

@JmPotato JmPotato requested a review from rleungx April 25, 2024 03:42
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.88764% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 77.38%. Comparing base (50c8040) to head (435b7f8).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8123   +/-   ##
=======================================
  Coverage   77.37%   77.38%           
=======================================
  Files         471      471           
  Lines       61252    61257    +5     
=======================================
+ Hits        47393    47401    +8     
+ Misses      10297    10291    -6     
- Partials     3562     3565    +3
Flag Coverage Δ
unittests 77.38% <89.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato JmPotato force-pushed the improve_tso_stream_switch branch from 4553b7f to d64c3f6 Compare April 25, 2024 04:02
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
rleungx
rleungx reviewed Apr 25, 2024
View reviewed changes
client/tso_dispatcher.go Outdated Show resolved Hide resolved
@JmPotato JmPotato requested a review from rleungx April 25, 2024 09:19
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2024
HuSharp
HuSharp reviewed Apr 28, 2024
View reviewed changes
client/tso_client.go
@@ -178,6 +178,14 @@ func (c *tsoClient) getTSORequest(ctx context.Context, dcLocation string) *tsoRe
return req
}

func (c *tsoClient) getTSODispatcher(dcLocation string) (*tsoDispatcher, bool) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this function need to be put in tso_dispatcher.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the explain: #8121 (comment)

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2024
JmPotato added 7 commits April 28, 2024 15:03
@JmPotato
Improve the switching of TSO stream
c95fe99 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Refine the code
6330a88 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Refine the comments
02329ac 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Extract connectionCtxsUpdater
13c5217 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Rename some context variables
7c11e8e 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Update the comment
583cea7 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Address the comments
435b7f8 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the improve_tso_stream_switch branch from 6a680c6 to 435b7f8 Compare April 28, 2024 07:32
@HuSharp
Copy link
Member

HuSharp commented Apr 28, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 435b7f8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit aae410f into tikv:master Apr 28, 2024
26 checks passed
@JmPotato JmPotato deleted the improve_tso_stream_switch branch April 28, 2024 08:09
@JmPotato JmPotato mentioned this pull request Apr 28, 2024
Closed
6 tasks
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 29, 2024
@JmPotato @nolouch
client/tso: improve the switching of TSO stream (tikv#8123)
5437f5e 
close tikv#7997, ref tikv#8047

Previously, without enabling the TSO Follower Proxy, we only passively update its stream when a TSO request fails.
This means that we cannot automatically and gradually complete the TSO stream update after a service switch.
This PR strengthens this logic, which can improve the success rate of TSO requests during service switching.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this pull request Apr 30, 2024
Merged
@Lily2025 Lily2025 mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@rleungx rleungx rleungx approved these changes

@HuSharp HuSharp HuSharp approved these changes

Assignees
No one assigned
Labels
component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After the leader changed, the first tso request cannot be directly forwarded to the new leader
4 participants
@JmPotato @HuSharp @nolouch @rleungx