Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check label strictly by adding more store info #1571

Open
overvenus opened this issue Jun 11, 2019 · 3 comments
Open

Check label strictly by adding more store info #1571

overvenus opened this issue Jun 11, 2019 · 3 comments
Labels
status/discussion-wanted The issue needs to be discussed.

Comments

@overvenus
Copy link
Member

User may have misconfigured labels, such as two different labels on one machine. This may misguide PD to schedule the majority peers on the machine. When it is down, TiDB cluster may not make progress.

To prevent this error, we can add additional info in the PutStoreRequest, such as hostname or IP. PD can check label strictly using this info.

Cc @nolouch

@disksing
Copy link
Contributor

disksing commented Jun 11, 2019

I personally don't like the idea. It is better not to expect the software to do the right thing in the wrong configuration because it inevitably leads to doing the wrong thing in the right configuration. For example, what if 2 hosts have the same hostname? What if 2 tikv-servers from different hosts share the same address (entirely possible, such as using DNS or NAT)?

@overvenus overvenus added the status/discussion-wanted The issue needs to be discussed. label Jun 11, 2019
@siddontang
Copy link
Contributor

here the main problem is that if the user misconfigures the label, how can we do it? still providing the services or not?

@disksing
Copy link
Contributor

I believe that the service should be provided according to the user's configuration, based on the fact that we can't accurately determine whether the configuration is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/discussion-wanted The issue needs to be discussed.
Projects
None yet
Development

No branches or pull requests

3 participants