Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading store state #1566

Open
disksing opened this issue Jun 5, 2019 · 3 comments
Open

Misleading store state #1566

disksing opened this issue Jun 5, 2019 · 3 comments
Labels
needs-type Indicates an issue requires a type label. status/discussion-wanted The issue needs to be discussed.

Comments

@disksing
Copy link
Contributor

disksing commented Jun 5, 2019

Currently, the status of down/disconnect is not reflected in the meta information of the store. As long as you do not manually go offline, the meta is always Up. This leads to the inability to determine the down state when using the grpc or HTTP interface to query the meta information of the store, and it is easy to mistake it as normal (but not).

Proposal: Define new state to use in the API, distinguish from that persistent to storage.

@disksing disksing added the status/discussion-wanted The issue needs to be discussed. label Jun 5, 2019
rleungx added a commit to rleungx/pd that referenced this issue Dec 1, 2021
close tikv#1566

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Mar 3, 2022
ref #1566

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@rleungx
Copy link
Member

rleungx commented Apr 1, 2022

Closed by #4687.

@rleungx rleungx closed this as completed Apr 1, 2022
@rleungx
Copy link
Member

rleungx commented Jan 7, 2025

The down/disconnect issue still exists, reopen it.

@rleungx rleungx reopened this Jan 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

There are no type labels on this issue. Please add an appropriate label by using the following command:

  • /type <type-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-type Indicates an issue requires a type label. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-type Indicates an issue requires a type label. status/discussion-wanted The issue needs to be discussed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants