az-jenkins-controller: handle auth by delegating to oauth2-proxy #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
flokli
commented
Jan 22, 2025
flokli
commented
|
This is currently blocked on the oauth2 application setup, as the one that's configured isn't allowed to see membership in the |
flokli
force-pushed
the
jenkins-reverseproxyauth
branch
from
cd525f8 to
05c360c
Compare
flokli
force-pushed
the
jenkins-reverseproxyauth
branch
from
05c360c to
30200f0
Compare
This changes the jenkins-casc variable to be a data structure, which can be extended later on. We write it out to JSON (which is also valid YAML of course), to be re-ingested by Jenkins. We cannot keep YAML as an input format, as Nix cannot parse YAML without using IFD. Signed-off-by: Florian Klink <flokli@flokli.de>
This means we can stop using jenkins-job-builder, which wants to authenticate using jenkins-cli. Signed-off-by: Florian Klink <flokli@flokli.de>
This configures caddy to delegate authentication to a deployment of oauth2-proxy, which will redirect the user to GitHub for authentication. We peek at the user profile, and in case they're part of the tiiuae organization, let them in. As GitHub redirects back to the application after the users consent, we need to have one GitHub application per Jenkins deployment. Said GitHub OAuth application also needs to have access to see membership in the tiiuae application. This will become easier in the future by adding a "trampoline" IdP like Dex in between, allowing us to manage individual clients and their redirect URIs locally, with only the Dex URL needing to be configured in GitHub. Once the user gets redirected back, it's passed through to Jenkins. We inject certain X-Forwarded-* headers into the request, which Jenkins picks up. Signed-off-by: Florian Klink <flokli@flokli.de>
The only thing this systemd service still did was disabling the initial setup, by running a groovy script (via jenkins-cli), and then triggering a Jenkins reboot. As we don't need the initial password anymore, we can simply disable the setup wizard entirely, and remove the need for that unit alltogether. Signed-off-by: Florian Klink <flokli@flokli.de>
flokli
force-pushed
the
jenkins-reverseproxyauth
branch
from
30200f0 to
f7b05ff
Compare
|
Depends on #361. Might also need changes to deal with authentication of the agents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.