Update stubs #726
Merged
Update stubs #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..✓..............✓.✓..............✓......................................... ........................................ ──────────────────────────────────────────────────────────────────── Laravel FIXED .................................. 116 files, 4 style issues fixed ✓ tests/FilesystemTest.php php_unit_method_casing ✓ tests/HelpersTest.php php_unit_method_casing ✓ tests/IterableObjectTest.php class_definition, php_unit_method_casing, br… ✓ tests/PaginationTest.php php_unit_method_casing )
gcavanunez
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
I think this guy is maybe causing the issue, we should add it to the gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gcavanunez,
I prepared this PR to be merged into yours. It essentially updates the stubs Jigsaw comes with.
In your PR, you laid out a set of steps to use Vite with Jigsaw. These steps include:
"type": "module"to yourpackage.jsonvite.config.jspackage.jsonpostcss.config.jsWith this PR merged into yours, those steps will already be done because the
initcommand will copy these new stubs.Now, I am experiencing issues with hot reloading. On my local setup, it is not always hot reloading as expected. But following your steps, hot reloading works, so I wonder if the issue is in a specific version of the dependencies updated in
package-lock.json.So I'd recommend creating an app and using this branch:
...and see if your local hot module reloading works as expected, to check if you experience the same issue or not. If you merge this into yours, feel free to squash the commits.
Thank you!