Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_launcher): initialize parameters for new concatenate node #337

Merged

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Oct 30, 2024

This PR introduces a new concatenation algorithm with configurable parameters.

All projects using the concatenation algorithm will need updates to their parameter settings. Additionally, this is a good opportunity to have launch files load parameters from a file rather than hardcoding them in each launcher.

related link:
autowarefoundation/sample_sensor_kit_launch#108

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf
Copy link
Contributor Author

vividf commented Oct 30, 2024

xx1 gen1 test

xx1gen1.mp4

@vividf
Copy link
Contributor Author

vividf commented Oct 31, 2024

@Autumn60
As I'm unsure who the maintainer for the X1 project is and noticed you worked on the launcher, I’d like to ask you—or anyone you know who is responsible for the X1 project—to follow the instructions in the provided TIERIV_INTERNAL_LINK

@TomohitoAndo
For the x2 gen1, please also follow the provided TIERIV_INTERNAL_LINK and record a rosbag for verification :)

If possible, we’d like to merge the PR as soon as possible. Thank you!

@vividf
Copy link
Contributor Author

vividf commented Oct 31, 2024

xx1 gen2 test

image

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf vividf changed the title feat(aip_launcher): initialize parameters for concatenate feat(aip_launcher): initialize parameters for new concatenate node Oct 31, 2024
@Autumn60
Copy link
Contributor

@vividf
Thank you. I will share this PR with other maintainers for X1.
FYI, the representative maintainer for X1 is @1222-takeshi

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf vividf marked this pull request as ready for review November 6, 2024 16:01
@vividf vividf requested review from drwnz and Autumn60 November 6, 2024 16:01
@vividf vividf self-assigned this Nov 6, 2024
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf vividf requested review from knzo25 and yukkysaito December 4, 2024 03:33
@vividf
Copy link
Contributor Author

vividf commented Jan 20, 2025

@YoshiRi @drwnz kindly ping

@vividf vividf requested a review from mojomex January 21, 2025 02:52
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@vividf vividf merged commit 01d06ab into tier4:tier4/universe Jan 21, 2025
8 of 9 checks passed
@SakodaShintaro
Copy link
Contributor

@vividf

After merging the pull request, the LiDAR started blinking when using logging_simulator with sample rosbag.

https://tier4.enterprise.slack.com/files/U04USA57R0C/F089F5TD2F7/simplescreenrecorder-2025-01-21_15.56.44.mp4

Procedure

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$HOME/autoware_map/sample-map-rosbag \
    vehicle_model:=lexus \
    sensor_model:=aip_xx1 
ros2 bag play $HOME/autoware_map/sample-rosbag/sample.db3 -r 0.5 -s sqlite3

Are there any parameters that need adjusting?

@vividf
Copy link
Contributor Author

vividf commented Jan 21, 2025

Sorry as I am on the business trip now I cannot reproduce the result.

From what I see is that you use the xx1 parameter to run the sample rosbag.

Could you follow the guide from the readme to set your parameter. Or use the parameter from sample sensor kit in order to run the sample rosbag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants