-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aip_launcher): initialize parameters for new concatenate node #337
feat(aip_launcher): initialize parameters for new concatenate node #337
Conversation
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
xx1 gen1 test xx1gen1.mp4 |
@Autumn60 @TomohitoAndo If possible, we’d like to merge the PR as soon as possible. Thank you! |
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf |
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
4f2de83
to
470e1e0
Compare
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
After merging the pull request, the LiDAR started blinking when using Procedure
ros2 launch autoware_launch logging_simulator.launch.xml \
map_path:=$HOME/autoware_map/sample-map-rosbag \
vehicle_model:=lexus \
sensor_model:=aip_xx1 ros2 bag play $HOME/autoware_map/sample-rosbag/sample.db3 -r 0.5 -s sqlite3 Are there any parameters that need adjusting? |
Sorry as I am on the business trip now I cannot reproduce the result. From what I see is that you use the xx1 parameter to run the sample rosbag. Could you follow the guide from the readme to set your parameter. Or use the parameter from sample sensor kit in order to run the sample rosbag. |
This PR introduces a new concatenation algorithm with configurable parameters.
All projects using the concatenation algorithm will need updates to their parameter settings. Additionally, this is a good opportunity to have launch files load parameters from a file rather than hardcoding them in each launcher.
related link:
autowarefoundation/sample_sensor_kit_launch#108