Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always separate lidar preprocessing from pointcloud_container #197

Merged
merged 12 commits into from
Jan 19, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 16, 2024

See autowarefoundation/autoware.universe#6091

  • LiDAR preprocessing nodes will no longer be attached to /pointcloud_container regardless of use_pointcloud_container

kminoda and others added 2 commits January 16, 2024 18:04
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title feat: update aip_xx1 feat!: replace use_pointcloud_container Jan 16, 2024
kminoda and others added 6 commits January 16, 2024 18:16
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title feat!: replace use_pointcloud_container feat: always separate lidar preprocessing from pointcloud_container Jan 16, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review January 16, 2024 13:58
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 90b7aba into tier4/universe Jan 19, 2024
9 of 10 checks passed
@kminoda kminoda deleted the feat/replace_use_pointcloud_container branch January 19, 2024 01:00
kminoda added a commit that referenced this pull request Feb 2, 2024
…197)

* feat: update aip_xx1

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* fix: fix for xx1

* feat: update aip_x1

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* feat: update aip_x2

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* revert: revert rename of use_pointcloud_container

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* change default container name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: fix comment

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: fix comment

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants