Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add clang format CI action #18

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

evgenykor
Copy link
Collaborator

No description provided.

@evgenykor evgenykor force-pushed the kornev/add_format_CI_action branch 2 times, most recently from cfcc3f7 to a9deb68 Compare January 13, 2025 09:18
@evgenykor evgenykor force-pushed the kornev/add_format_CI_action branch from a9deb68 to 501a47c Compare January 13, 2025 09:19
@evgenykor
Copy link
Collaborator Author

evgenykor commented Jan 13, 2025

@guycipher these clang-format checks (CI actions) are looking good you may want to have them in tidesdb

@evgenykor evgenykor merged commit a9c32dc into master Jan 13, 2025
3 checks passed
@guycipher
Copy link
Member

We could. Usually it’s run before putting in PR on my end. Because the CI is using ubuntu you can do
sh code-formatter.sh

as well there is a bash script I made as well.

@evgenykor
Copy link
Collaborator Author

This CI action is better than running your scripts for several reasons:

*it specifies the version of clang-format (for instance I tried version 19 and the result of formatting is slightly different)
*your script is formatting actual file instead of check for violation rules - i.e. do "dry-run" for it instead
*your script needs --Werror to treat all warnings as errors so we could easily pick up it as a failure for CI

TLDR - just use this action for verification and your script for actual formatting

@guycipher
Copy link
Member

Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants