Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clang format, added code_formatter.sh, formatted code, added he… #15

Merged

Conversation

guycipher
Copy link
Member

Added clang format, added code_formatter.sh, formatted code, added header comments.

@guycipher
Copy link
Member Author

@evgenykor I may need your help here. I can't get Lua installed on my computer. I have to reinstall my OS. My linux is a bit corrupt. We made a change to TidesDB, same stuff, as per usual it should work the only change we did is to make sure all .h within a system include directory sit in a subdirectory called tidesdb. So include/tidesdb. This doesn't have any affect or shouldnt on the cmake process. For example with the golang package I just link to tidesdb, no problem. Not sure why this workflow isn't grabbing the library. I am almost thinking to do a sudo ldconfig and see if that works.

@guycipher
Copy link
Member Author

guycipher commented Jan 9, 2025

I cant reproduce locally.

I install latest master of tidesdb locally, and everything works locally including the lua code and cmake. Just on the CI its failing.
I do

cmake -S . -B build
cmake --build build
sudo cmake --install build
sudo ldconfig

And no problem library is installed and can use. Very odd. Maybe I am missing something regarding how lua works.

agpmastersystem@agpmastersystem:~/tdb22/tidesdb$ cmake -S . -B build
-- The C compiler identification is GNU 12.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/agpmastersystem/tdb22/tidesdb/build
agpmastersystem@agpmastersystem:~/tdb22/tidesdb$ cmake --build build
[  3%] Building C object CMakeFiles/tidesdb.dir/src/tidesdb.c.o
[  6%] Building C object CMakeFiles/tidesdb.dir/src/err.c.o
[  9%] Building C object CMakeFiles/tidesdb.dir/src/block_manager.c.o
[ 12%] Building C object CMakeFiles/tidesdb.dir/src/skip_list.c.o
[ 16%] Building C object CMakeFiles/tidesdb.dir/src/compress.c.o
[ 19%] Building C object CMakeFiles/tidesdb.dir/src/bloom_filter.c.o
[ 22%] Building C object CMakeFiles/tidesdb.dir/src/hash_table.c.o
[ 25%] Building C object CMakeFiles/tidesdb.dir/src/binary_hash_array.c.o
[ 29%] Building C object CMakeFiles/tidesdb.dir/src/log.c.o
[ 32%] Building C object CMakeFiles/tidesdb.dir/external/xxhash.c.o
[ 35%] Linking C shared library libtidesdb.so
[ 35%] Built target tidesdb
[ 38%] Building C object CMakeFiles/err_tests.dir/test/err__tests.c.o
[ 41%] Linking C executable err_tests
[ 41%] Built target err_tests
[ 45%] Building C object CMakeFiles/block_manager_tests.dir/test/block_manager__tests.c.o
[ 48%] Linking C executable block_manager_tests
[ 48%] Built target block_manager_tests
[ 51%] Building C object CMakeFiles/skip_list_tests.dir/test/skip_list__tests.c.o
[ 54%] Linking C executable skip_list_tests
[ 54%] Built target skip_list_tests
[ 58%] Building C object CMakeFiles/hash_table_tests.dir/test/hash_table__tests.c.o
[ 61%] Linking C executable hash_table_tests
[ 61%] Built target hash_table_tests
[ 64%] Building C object CMakeFiles/compress_tests.dir/test/compress__tests.c.o
[ 67%] Linking C executable compress_tests
[ 67%] Built target compress_tests
[ 70%] Building C object CMakeFiles/bloom_filter_tests.dir/test/bloom_filter__tests.c.o
[ 74%] Linking C executable bloom_filter_tests
[ 74%] Built target bloom_filter_tests
[ 77%] Building C object CMakeFiles/log_tests.dir/test/log__tests.c.o
[ 80%] Linking C executable log_tests
[ 80%] Built target log_tests
[ 83%] Building C object CMakeFiles/binary_hash_array_tests.dir/test/binary_hash_array__tests.c.o
[ 87%] Linking C executable binary_hash_array_tests
[ 87%] Built target binary_hash_array_tests
[ 90%] Building C object CMakeFiles/tidesdb_tests.dir/test/tidesdb__tests.c.o
[ 93%] Linking C executable tidesdb_tests
[ 93%] Built target tidesdb_tests
[ 96%] Building C object CMakeFiles/tidesdb_bench.dir/bench/tidesdb__bench.c.o
[100%] Linking C executable tidesdb_bench
[100%] Built target tidesdb_bench
agpmastersystem@agpmastersystem:~/tdb22/tidesdb$ sudo cmake --install build
-- Install configuration: ""
-- Installing: /usr/local/lib/libtidesdb.so
-- Installing: /usr/local/include/tidesdb
-- Installing: /usr/local/include/tidesdb/hash_table.h
-- Installing: /usr/local/include/tidesdb/log.h
-- Installing: /usr/local/include/tidesdb/compat.h
-- Installing: /usr/local/include/tidesdb/bloom_filter.h
-- Installing: /usr/local/include/tidesdb/binary_hash_array.h
-- Installing: /usr/local/include/tidesdb/block_manager.h
-- Installing: /usr/local/include/tidesdb/compress.h
-- Installing: /usr/local/include/tidesdb/skip_list.h
-- Installing: /usr/local/include/tidesdb/tidesdb.h
-- Installing: /usr/local/include/tidesdb/err.h
-- Installing: /usr/local/include/tidesdb/xxhash.h
-- Installing: /usr/local/lib/cmake/tidesdb/TidesDBConfig.cmake
-- Installing: /usr/local/lib/cmake/tidesdb/TidesDBConfigVersion.cmake

@guycipher
Copy link
Member Author

Oh I know what it is. It's the inclusion path.

@guycipher guycipher merged commit 68a96bf into master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant