Dont use default crypto in chains #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for the PR and I'll happily merge it but could you look at CI, please? It seems your PR has broken some tests. |
|
I had the same test failing locally, it is not related to these changes (it
was failing on master branch as well, some behaviour might have changed,
Empty returns true for Crypto), I can include the fix though, I will do
that tomorrow as on holiday today.
thanks again!
…On Fri, Aug 17, 2018, 10:39 AM Ivan Tomilov ***@***.***> wrote:
Hi! Thank you for the PR and I'll happily merge it but could you look at
CI, please? It seems your PR has broken some tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-EsFFujl2cO8g57AFZIGBhYXBeHgpbks5uRoE8gaJpZM4V_ZxJ>
.
|
|
Yeah, if you're going to integrate this library (glad that Status is able to integrate the Double Ratchet at last), it'll be useful for you to get hands dirty even for that small fix. Thank you in advance and let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultCryptowas used in the chains even ifWithCryptohas been passed as an option, I have changed the code so that it sets them all before performing any action.Feel free to merge if useful, thanks!