add location endpoint #2481
Merged
add location endpoint #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add location endpoint to get this file info
Omarabdul3ziz
requested review from
muhamadazmy,
ashraffouda,
rawdaGastan,
xmonader and
Eslam-Nawara
as code owners
iwanbk
reviewed
Nov 11, 2024
pkg/registrar/register.go
Outdated
| @@ -231,3 +237,13 @@ func ensureTwin(ctx context.Context, substrateGateway *stubs.SubstrateGatewayStu | |||
|
|
|||
| return twinID, nil | |||
| } | |||
|
|
|||
| func writeLocationOnFile(loc geoip.Location, filepath string) error { | |||
| file, err := os.OpenFile(filepath, os.O_RDWR|os.O_CREATE, 0644) | |||
There was a problem hiding this comment.
is it possible for the file to already exists?
If possible, what is the default behavior? Is truncate or append?
iwanbk
reviewed
Nov 11, 2024
pkg/zos_api/location.go
Outdated
| ) | ||
|
|
||
| func (g *ZosAPI) locationGet(ctx context.Context, payload []byte) (interface{}, error) { | ||
| if _, err := os.Stat(geoip.LocationFile); err != nil { |
xmonader
requested changes
Nov 11, 2024
4 tasks
xmonader
reviewed
Nov 13, 2024
pkg/zos_api/location.go
Outdated
| var loc geoip.Location | ||
| err = json.NewDecoder(f).Decode(&loc) | ||
| return loc, err | ||
| return geoip.Fetch() |
There was a problem hiding this comment.
at this point you can add caching if needed
There was a problem hiding this comment.
I agree, the node location should be updated like once per day and then cached for full day before it's fetched again.
|
i will draft until we finish releasing today |
muhamadazmy
previously approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Thank @Omarabdul3ziz for implementing this. It looks good to me. It's yet a good idea to cache the location of the node to avoid un-necessary load on the location service as per @xmonader comment
Eslam-Nawara
approved these changes
Dec 12, 2024
iwanbk
approved these changes
Dec 31, 2024
xmonader
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist