Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge Solana #811

Draft
wants to merge 24 commits into
base: development
Choose a base branch
from
Draft

Bridge Solana #811

wants to merge 24 commits into from

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Dec 19, 2024 •
edited
Loading

Changes

  • Edit bridge design to include Solana
  • Refactor bridge

image

image

image

Related Issues

Tested Scenarios

  • Swap multiple chains
  • Change the selected chain and review the fee changes
  • Solana should never be in the left chains
  • to address should be removed on chain change
  • Contact icon should be hidden if Solana is current to chain
  • Swap should be disabled if Solana is chosen

@zaelgohary
Edit bridge design to include solana, refactor bridge
773862d
@zaelgohary
Fix left & right chain labels, edit selectedChain
04753ae
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
0a95b71 
…old_connect into development_bridge_solana
@zaelgohary
Fix swap styling, fix swapping, exclude left chain from right dropdown
02ef093
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
f2650bc 
…old_connect into development_bridge_solana
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
5c3b1e0 
…old_connect into development_bridge_solana
@zaelgohary
Filter dropdowns based on selected chains, add selected chain default…
c2982a7 
… value, fix swapping, refactor dropdown
@zaelgohary
Update current operation on chain change
0db5400
@zaelgohary
Add Solana validation, simple refactor
eeaee3d
@zaelgohary
Add Solana fee, edit validation
d50c402
@zaelgohary
Remove unused enum
5ec5371
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
d99ee11 
…old_connect into development_bridge_solana
@zaelgohary
Fix fee & bridge validation
97669c2
@zaelgohary
Fix fee & solana validation, add memoHash
12b02ec
@zaelgohary
Revert precommit changes
1173b34
@zaelgohary
Revert precommit changes, make memHash optional positional arg
a099099
@zaelgohary
Revert testnet changes
937634f
@zaelgohary zaelgohary marked this pull request as ready for review January 28, 2025 11:17
AlaaElattar
AlaaElattar reviewed Jan 29, 2025
View reviewed changes
app/lib/widgets/wallets/swap_transaction_widget.dart
_initializeChains();
}

void _initializeChains() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we can make Stellar, TF Chain and Solana enum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@AlaaElattar
Copy link
Contributor

  • As it requires to have XLMs, I think we should add hint or note to notify user about having them.

@zaelgohary zaelgohary marked this pull request as draft January 29, 2025 15:06
@zaelgohary
Copy link
Contributor Author

Will keep this drafted till bridge is on mainnet.

@xmonader
Copy link
Contributor

xmonader commented Jan 30, 2025 •
edited
Loading

It can be disabled with feature flags no?

@zaelgohary
Copy link
Contributor Author

It can be disabled with feature flags no?

Yes but not implemented. Should I?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @AlaaElattar @xmonader