-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-1895 Created action to release on tag. #49
Conversation
I was then able to add the GithubPackage as a repo to gradle, and with this code I was able to call the api:
however, 2 things that I noticed and will change in the generator regarding the READMEs: 1- We also need to import the Client + NativeClient, not only the
and in the README we tell users that they simply need to install 1 package. 2- The example mentions a
|
build.gradle
Outdated
id = 'api-team' | ||
name = 'ThousandEyes API Team' | ||
email = 'api-team@thousandeyes.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if we should "expose" this info, maybe something to confirm with the Cisco team that is handling this process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is mandatory to publish to Maven. But I confirmed with Natali if these should be our info or Cisco user/email, waiting on them to give an answer!
def signingKey = findProperty("signingKey") | ||
def signingPassword = findProperty("signingPassword") | ||
useInMemoryPgpKeys(signingKeyId, signingKey, signingPassword) | ||
sign publishing.publications.mavenJava |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested signing in my fork with success: https://github.com/joaomper-TE/thousandeyes-sdk-java/actions/runs/10092947203/job/27907810804
To test this, I had to publish my public key: https://keyserver.ubuntu.com/pks/lookup?search=285F2CE5D7685EF752285EA6DC8F325428A11005&fingerprint=on&op=index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, and because I spent a lot of time banging my head around this, if the ORG_GRADLE_PROJECT_signingKeyId
is not the short
version of the key or if the private key is not in a specific format we get an error "> Could not read PGP secret key"
To export the private key correctly, we should use
gpg --armor --export-secret-keys <keyId> \
| awk 'NR == 1 { print "ORG_GRADLE_PROJECT_signingKey=" } 1' ORS='\\n'
} | ||
|
||
signing { | ||
def signingKeyId = findProperty("signingKeyId") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks for a property called ORG_GRADLE_PROJECT_signingKeyId
. More on this.
Tested a slightly different approach in my fork, uploading the packages to Github Packages. The end result can be seen here:
Still missing: