Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with provisional logo #50

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

codeofdiego
Copy link
Contributor

This PR includes a provisional logo to be used in the Belt repo until we design a final one. There's currently a task on Space Station to handle this once there's design time available.

@codeofdiego codeofdiego self-assigned this Aug 21, 2024
README.md Outdated
@@ -1,3 +1,7 @@
<div align="center" style="padding: 30px 0px 20px 0px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the 30px on top looks good. Probably 20px makes it even between top and bottom.

Copy link
Contributor

@rakeshpetit rakeshpetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I left a minor comment about padding.

Copy link

@stevehanson stevehanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brown splatters are... not super palatable to me. What would we think of changing them to some other color?

Before After
359940861-95171e10-a4cd-474e-9bb2-c95524f39b6a belt-blue

Happy to share some other color options if we are open to this. I also would probably vote to remove the splatters altogether. Happy to propose a final design, just wanted to gauge direction first!

@stevehanson
Copy link

stevehanson commented Aug 22, 2024

Here's a quick revision with the splatters removed and with a more reddish belt and blue background. I chose those since red and blue are both in thoughtbot's brand colors, but I also didn't spend much time to get them exact. What do we think? Feel free to ignore these suggestions if I'm overstepping!

belt

Copy link

@stevehanson stevehanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this forward! A rebase should fix the CI error!

README.md Outdated Show resolved Hide resolved
codeofdiego and others added 3 commits August 22, 2024 14:32
This PR includes a provisional logo to be used in the Belt repo until we design a final one. There's currently a task on Space Station to handle this once there's design time available.
Co-authored-by: Stephen Hanson <shanson@thoughtbot.com>
@codeofdiego
Copy link
Contributor Author

Thank you all for the reviews!

@codeofdiego codeofdiego merged commit 6f7cdce into main Aug 22, 2024
2 checks passed
@codeofdiego codeofdiego deleted the provisional-logo branch August 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants