-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with provisional logo #50
Conversation
README.md
Outdated
@@ -1,3 +1,7 @@ | |||
<div align="center" style="padding: 30px 0px 20px 0px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the 30px
on top looks good. Probably 20px
makes it even between top and bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I left a minor comment about padding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The brown splatters are... not super palatable to me. What would we think of changing them to some other color?
Before | After |
---|---|
Happy to share some other color options if we are open to this. I also would probably vote to remove the splatters altogether. Happy to propose a final design, just wanted to gauge direction first!
Here's a quick revision with the splatters removed and with a more reddish belt and blue background. I chose those since red and blue are both in thoughtbot's brand colors, but I also didn't spend much time to get them exact. What do we think? Feel free to ignore these suggestions if I'm overstepping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this forward! A rebase should fix the CI error!
This PR includes a provisional logo to be used in the Belt repo until we design a final one. There's currently a task on Space Station to handle this once there's design time available.
Co-authored-by: Stephen Hanson <shanson@thoughtbot.com>
4c2e485
to
7b2c5b7
Compare
Thank you all for the reviews! |
This PR includes a provisional logo to be used in the Belt repo until we design a final one. There's currently a task on Space Station to handle this once there's design time available.