Popups broken in 0.113

[VDRainer]

Log

2020-07-17 08:40:29 ERROR (MainThread) [frontend.js.latest.202007160] http://192.168.77.67:8123/browser_mod.js:1:5017 TypeError: r is undefined

Console

[TheRealBadRobot]

I confirm it with 0.113.0. I have same issue.

[ksheyman]

yep same exact thing for me. just upgraded to .113 and no popups work at all

edit: I rolled back and they work again.

[theone11]

same here 0.113 release
ERROR (MainThread) [frontend.js.latest.202007160] http://192.168.1.17:8123/browser_mod.js:1:5019 Uncaught TypeError: Cannot read property 'close' of undefined

[BradAndAU]

Exact same thing here with 0.113 release.
2020-07-23 09:06:01 ERROR (MainThread) [frontend.js.latest.202007160] http://10.0.1.9:8123/browser_mod.js:1:5019 Uncaught TypeError: Cannot read property 'close' of undefined

[carldanley]

My popups continue to work; the only issue I've been having thus far has been:

2020-07-23 01:08:52 ERROR (MainThread) [frontend.js.latest.202007160] https://redacted/browser_mod.js:1:6630 Uncaught TypeError: Cannot set property 'large' of undefined

EDIT: Confirmed. I am definitely not able to open popups for all of the same reasons mentioned here already.

[Alfiegerner]

Exact same thing here with 0.113 release.
2020-07-23 09:06:01 ERROR (MainThread) [frontend.js.latest.202007160] http://10.0.1.9:8123/browser_mod.js:1:5019 Uncaught TypeError: Cannot read property 'close' of undefined

Same same.

[CAB426]

0.113 had some major changes to the frontend regarding more-info. You can check them out here.

What this means is the method used to find the more-info popup in card-tools is no longer working. You used to be able to find it using this:
document.querySelector("home-assistant")._moreInfoEl

Now for 0.113, you need to do something like this:
document.querySelector("home-assistant").shadowRoot.querySelector("ha-more-info-dialog").shadowRoot.querySelector("ha-dialog").getElementsByClassName("content")[0].querySelector("more-info-content")

I ran into this with some updates I made to custom-ui to bring back hiding attributes on the standard popup. Not sure exactly how to incorporate this into card-tools/browser-mod and have it be backwards compatible. Might not be possible, might just need to handle different versions differently. I am interested to see how this is resolved and hopefully I can use it in my custom-ui code.

[deluxestyle]

I see now the same issue after update to 0.113
is the developer already aware of this issue? It is breaking now my UI, as I have some stuff in popup cards

[Alfiegerner]

I see now the same issue after update to 0.113
is the developer already aware of this issue? It is breaking now my UI, as I have some stuff in popup cards

For now reverting back to 112.5 is your only option.

[paddenstoeltje]

Same problem over here, running HA0.113. No way to open a pop-up.

[polonel]

Along with everyone else I had to revert back due to the popups not working. Can't really rebuild my custom UI at this point to go back to the standard popup.

[jncanches]

I have spent a lot of time trying to temporarely fix this until @thomasloven review the code, but I have to forgive.
Too many code has been changed here. Open and close method does not exist anymore (there is a closeDialog and showDialog, but showDialog is failing).
I think a lot of code has to be reviewed :-(
The best result I have is my popup opens but only after I opened a standard "more-info" dialog. It is usable but it cannot be closed using buttons, and it is not centered on my screen.

[thomasloven]

I have a fix in the works.
There's been some really big changes to how the more-info dialog works, so I'll need to redo everything pretty much from scratch.
The end result will be better than what was before, though, but It'll take a day or two more.

[stephenmetts]

Many thanks for your efforts @thomasloven , I ran into the same issue and appreciate your efforts. If you would like any assistance testing, I'm happy to help.

[systemsNinja]

Lets all pool together some coffees for Thomas, for all that hard work he is/will be putting in!
Here is my contribution!

[ronaldheft]

Great idea @systemsNinja! I just contributed. Your plugins are awesome @thomasloven.

[fastender]

How I can contribute? Can I have a link?

[lars-str]

How I can contribute? Can I have a link?

https://www.buymeacoffee.com/uqD6KHCdJ

[thomasloven]

Should be fixed in release 1.1.0.
If you have the latest version of card-mod, you may get an error when you open a popup-card. This can be safely ignored, but I'll try to make it not happen in the next card-mod release.

[thomasloven]

I'll get ulcers from all that coffee.

Thank you everyone!

[hawk-is-afk]

@thomasloven, as usual great work and fast fixes - everything is back up and running great for me (no error on popup either). now go enjoy many many fika!

[carldanley]

Confirmed 1.1.0 is fixed - though a ton of styling is broken but I believe that's related to 0.113.0 changes.

Thanks for the quick turn-around @thomasloven !

[ronaldheft]

Popups are loading as well right now, but styling is broken with custom cards in the popup.

[fastender]

Yes, that's right, I have the same problem, unfortunately. Individual CSS Styles are somehow ignored.

[basesnow]

Popups are loading as well right now, but styling is broken with custom cards in the popup.

Im seeing the same thing. I have a vertical stack pop up, and the styling is completely different from the same vertical stack directly in my lovelace tab.

[joseska]

same here..... styles not applied

[systemsNinja]

service_data: title: Close deviceID: this style: width: 75em card: type: custom:hui-element card_type: iframe aspect_ratio: 50% title: WeatherMap url: >

That was a nice size map, is now tiny.. : (

Any workaround for setting the width?

[thomasloven]

Since styles don't really work anyway, I decided to move over to card-mod-style styles instead in 1.1.1.

See #117 for more info.

[holdestmade]

Thanks for the work on this, the title seems to be not working, all my popups have "true" instead of the configured title ?