incorporate readability feedback from review

thinkst · Jun 4, 2024 · 4019857 · 4019857
1 parent 1c19851
commit 4019857
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/canarytokens/channel_dns.py b/canarytokens/channel_dns.py
@@ -240,10 +240,9 @@ def query(self, query: Query, src_ip: str):  # noqa C901
         ):
             return defer.succeed(self._do_dynamic_response(name=query.name.name))
 
-        if (canarydrop.type == TokenTypes.CMD) and (
-            invocation_id := src_data["src_data"].get("cmd_invocation_id")
-        ):
-            if any(
+        if canarydrop.type == TokenTypes.CMD:
+            invocation_id = src_data["src_data"].get("cmd_invocation_id")
+            if (invocation_id is not None) and any(
                 hit.src_data.get("cmd_invocation_id") == invocation_id
                 for hit in canarydrop.triggered_details.hits
             ):