Merge Beta to Main #104
Merged
Merge Beta to Main #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter readability; add details for fund_type param in docstring
some columns might have negative timestamp, it's better for code readability to use an utils function to convert timestamp and handle error. Other functions like fund_details can also benefits from this
convert to date format only when mode==full
* refactor: replace if else statement by dictionary lookup for better code readability * chores: remove unused code and not related comments * refactor: reassign data type of column id to int; reorder lines for better readability; add details for fund_type param in docstring * feat: add optional input param mode and decor for funds_listing * feat: add utils function to convert unix timestamp some columns might have negative timestamp, it's better for code readability to use an utils function to convert timestamp and handle error. Other functions like fund_details can also benefits from this * fix: patch bug of convert timestamp convert to date format only when mode==full
refactor validate symbol param; refactor validate type param; edit docstring; for better code readability
replace function param from payload to symbol; update docstring
add check_language_input utils function; edit docstring
add type hint for function
some initial test cases with more to come later; run: pytest ./tests/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.