Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeowners: add code owner to performance script #1142

Closed
wants to merge 1 commit into from

Conversation

btian1
Copy link
Contributor

@btian1 btian1 commented Dec 28, 2023

Add btian1 and andrula-song as script: sof_perf_analyzer.py codeowner.

@btian1 btian1 requested a review from a team as a code owner December 28, 2023 06:00
Add btian1 and andrula-song as script: sof_perf_analyzer.py
codeowner.

Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
@marc-hb
Copy link
Collaborator

marc-hb commented Dec 29, 2023

GitHub reports this does not work because you don't have "write" (=maintainer) access.

The easiest way to become maintainer is to be a member of "test-maintainers". Then you will be notified of every PR anyway (which is not many) and this CODEOWNERS change becomes pointless.

Per-file maintainership is really micro-management, I don't think this repo has enough traffic to require such micro-management.

@btian1
Copy link
Contributor Author

btian1 commented Jan 2, 2024

GitHub reports this does not work because you don't have "write" (=maintainer) access.

The easiest way to become maintainer is to be a member of "test-maintainers". Then you will be notified of every PR anyway (which is not many) and this CODEOWNERS change becomes pointless.

Per-file maintainership is really micro-management, I don't think this repo has enough traffic to require such micro-management.

@marc-hb , are we qualified add to test-maintainers?

@btian1
Copy link
Contributor Author

btian1 commented Jan 3, 2024

closing, as we are accepted by test-maintainer application.

@btian1 btian1 closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants